roachtest: fail fixture roachtests on failed backups #147635
Merged
+57
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kev-cao
force-pushed
the
roachtest/fixture-fail-backup
branch
from
0c82e0d to
47a628a
Compare
msbutler
approved these changes
Jun 3, 2025
Previously, if a backup job failed during the fixture roachtest, the test would continue along until the required number of backups completed. In this situation, if a backup failed for whatever reason, we would ignore it. This commit teaches the fixture roachtest to detect when a backup job has failed and to fail with the corresponding error. Epic: None Release note: None
kev-cao
force-pushed
the
roachtest/fixture-fail-backup
branch
from
47a628a to
bdee6f0
Compare
|
TFTR! bors r=msbutler |
msbutler
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a backup job failed during the fixture roachtest, the test would continue along until the required number of backups completed. In this situation, if a backup failed for whatever reason, we would ignore it. This commit teaches the fixture roachtest to detect when a backup job has failed and to fail with the corresponding error.
Epic: None
Release note: None