kvserver: deflake TestReadLoadMetricAccounting #141843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pav-kv
force-pushed
the
deflake-load-metric-test
branch
from
622c900 to
42e78a2
Compare
Occasionally, a leader lease upgrade request interferes with the metrics measured by this test. This commit makes it wait for the upgrade first, before checking metrics. Epic: none Releaste note: none
pav-kv
force-pushed
the
deflake-load-metric-test
branch
from
42e78a2 to
55d1505
Compare
tbg
approved these changes
Feb 21, 2025
Epic: none Release note: none
|
bors r=tbg |
arulajmani
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @pav-kv)
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, a leader lease upgrade request interferes with the metrics measured by this test. This commit makes it wait for the upgrade first, before checking metrics.
Fixes #141716