Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: crosscluster/logical: avoid panic in multi-table streams involving UDTs #141793

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

dt
Copy link
Member

@dt dt commented Feb 20, 2025

Backport 1/1 commits from #141634.

/cc @cockroachdb/release


Previously a single LDR stream involving multiple tables would fail to be created if the tables used user-defined types due to a bug in the helper used to resolve UDTs when called in a loop where successfully resolving a type returned a nil map that was then passed to the next call in the loop, causing it to panic.

Release note (bug fix): fix a bug that prevented starting multi-table LDR streams on tables that used user-defined types.
Epic: none.

Fixes #141598.

Release justification: bug fix.

Previously a single LDR stream involving multiple tables would fail to be created
if the tables used user-defined types due to a bug in the helper used to resolve UDTs
when called in a loop where successfully resolving a type returned a nil map that was
then passed to the next call in the loop, causing it to panic.

Release note (bug fix): fix a bug that prevented starting multi-table LDR streams on tables that used user-defined types.
Epic: none.

Fixes cockroachdb#141598.
@dt dt requested a review from msbutler February 20, 2025 18:17
@dt dt requested a review from a team as a code owner February 20, 2025 18:17
Copy link

blathers-crl bot commented Feb 20, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 20, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt merged commit 55dc245 into cockroachdb:release-24.3 Feb 20, 2025
15 of 16 checks passed
@dt dt deleted the backport24.3-141634 branch February 20, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches target-release-24.3.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants