-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker init script respect COCKROACH_DATABASE when processing SQL files #140650
Make docker init script respect COCKROACH_DATABASE when processing SQL files #140650
Conversation
…L files Should close cockroachdb#137735
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution! this looks good to me. i will merge it once the tests complete.
bors r+ |
Thanks @rafiss and the team for handling and merging it! |
This PR makes the docker init script run the SQL files in
docker-entrypoint-initdb.d
against the database specified byCOCKROACH_DATABASE
.The behaviour is aligned to Postgres's init script, and I believe it is beneficial for the most of use cases.
Should close #137735