Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-25.1: opt: do not project extra columns above partial index scans #140131

Merged
merged 1 commit into from
Jan 31, 2025
Merged

release-25.1: opt: do not project extra columns above partial index scans #140131

merged 1 commit into from
Jan 31, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 30, 2025 •
edited by mgartner
Loading

Backport 1/1 commits from #140034 on behalf of @mgartner.

/cc @cockroachdb/release

The GeneratePartialIndexScans rule no longer projects all non-indexed
columns held constant by the partial index predicate. Now, only columns
produced by the original scan are produced. This fixes an issue where
the generated Project expression could have more output columns than the
other expressions in its group, causing a test-only assertion to fail.

Fixes #140019

There is no release note because this has caused no known correctness
bugs.

Release note: None

Release justification: Low-risk bug fix.

@mgartner
opt: do not project extra columns above partial index scans
d4715dc 
The `GeneratePartialIndexScans` rule no longer projects all non-indexed
columns held constant by the partial index predicate. Now, only columns
produced by the original scan are produced. This fixes an issue where
the generated Project expression could have more output columns than the
other expressions in its group, causing a test-only assertion to fail.

Fixes #140019

There is no release note because this has caused no known correctness
bugs.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-140034 branch from 0c4a911 to d4715dc Compare January 30, 2025 18:03
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 30, 2025 18:03
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team January 30, 2025 18:03
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 30, 2025
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jan 30, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from DrewKimball January 30, 2025 18:03
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 30, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner

This comment was marked as outdated.

Sign in to view
@mgartner mgartner merged commit a2bf795 into release-25.1 Jan 31, 2025
19 of 20 checks passed
@mgartner mgartner deleted the blathers/backport-release-25.1-140034 branch January 31, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@rytaft rytaft Awaiting requested review from rytaft rytaft is a code owner automatically assigned from cockroachdb/sql-queries-prs

@DrewKimball DrewKimball Awaiting requested review from DrewKimball

Assignees

@mgartner mgartner

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @mgartner