Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrademanager: skip TestPrecondition under stress #140024

Merged
merged 1 commit into from
Jan 30, 2025
Merged

upgrademanager: skip TestPrecondition under stress #140024

merged 1 commit into from
Jan 30, 2025

Conversation

rail
Copy link
Member

@rail rail commented Jan 29, 2025

Fixes: #139562
Epic: none
Release note: None

@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure T-testeng TestEng Team backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 labels Jan 29, 2025
@rail rail requested a review from srosenberg January 29, 2025 14:15
@rail rail self-assigned this Jan 29, 2025
@rail rail requested review from a team as code owners January 29, 2025 14:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

srosenberg
srosenberg approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rail
Copy link
Member Author

rail commented Jan 30, 2025

bors r=srosenberg

@craig
Copy link
Contributor

craig bot commented Jan 30, 2025

Build succeeded:

@craig craig bot merged commit 7963889 into cockroachdb:master Jan 30, 2025
22 checks passed
@blathers-crl blathers-crl bot mentioned this pull request Jan 30, 2025
Closed
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Jan 30, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.

Issue #139562: branch-release-23.1, branch-release-23.2, branch-release-24.2, branch-release-24.3, branch-release-25.1.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

This was referenced Jan 30, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

Assignees

@rail rail

Labels
A-testing Testing tools and infrastructure backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-testeng TestEng Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/upgrade/upgrademanager/upgrademanager_test: TestPrecondition failed
3 participants
@rail @cockroach-teamcity @srosenberg