-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: move ExternalIODir into StorageConfig #139980
base: master
Are you sure you want to change the base?
storage: move ExternalIODir into StorageConfig #139980
Conversation
dc2fc79
to
4d2b81a
Compare
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
9435ee1
to
b831e3c
Compare
@RaduBerinde FYI - I'm investigating the failure in |
The failure in |
Previously the ExternalIODir was stored as a variable inside the BaseConfig struct and updated based on the StoreSpecs if it wasn't explicitly set. This commit moves it into the StorageConfig and removes it from the BaseConfig. Epic: CRDB-41111 Release note: None
b831e3c
to
523550f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that ExternalIODir belongs in storage.. It is not directly related to the stores. @jbowens WDYT? This is the definition:
// ExternalIODir is the local file path under which remotely-initiated
// operations that can specify node-local I/O paths (such as BACKUP, RESTORE
// or IMPORT) can access files.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @angles-n-daemons, @golgeek, @herkolategan, @jbowens, @michae2, @msbutler, and @rharding6373)
Previously the ExternalIODir was stored as a variable inside the
BaseConfig struct and updated based on the StoreSpecs if it wasn't
explicitly set. This commit moves it into the StorageConfig and removes
it from the BaseConfig.
Epic: CRDB-41111
Release note: None