Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_3DLength #139450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

qburke
Copy link

@qburke qburke commented Jan 20, 2025

This patch allows measuring the length of 3D geometries when there was no builtin function to do this before.

Release note (sql change): The ST_3DLength function is now available for use.
Fixes: #60866

@qburke qburke requested review from a team as code owners January 20, 2025 16:09
Copy link

blathers-crl bot commented Jan 20, 2025

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jan 20, 2025
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 20, 2025

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

blathers-crl bot commented Jan 22, 2025

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Jan 22, 2025

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

This patch allows measuring the length of 3D geometries when there
was no builtin function to do this before.

Release note (sql change): The `ST_3DLength` function is now available
for use.
Fixes: cockroachdb#60866
Copy link

blathers-crl bot commented Jan 22, 2025

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@DrewKimball DrewKimball requested review from a team and michae2 and removed request for a team January 27, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_3DLength({geometry})
2 participants