Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-25.1: rowexec: add concurrency to ingestIndexEntries #139216

Merged
merged 3 commits into from
Jan 16, 2025
Merged

release-25.1: rowexec: add concurrency to ingestIndexEntries #139216

merged 3 commits into from
Jan 16, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 16, 2025 •
edited by rafiss
Loading

Backport 3/3 commits from #138781 on behalf of @rafiss.

/cc @cockroachdb/release

Ingesting the index entries them and writing them in bulk is the most expensive part of an index backfill, and it's mostly I/O bound. Profiles show that there is also a fair amount of computational overhead during this step, so using an additional goroutine will allow more work to be performed in parallel while the other goroutine is doing I/O.

informs #137797
Release note: None

Release justification: performance improvement

rafiss added 3 commits January 9, 2025 23:38
@rafiss
sql: remove unnecessary test
8f28d08 
This test was written 6 years ago, and it asserts things about the
internals of schema changes. This level of testing is overly specific,
and makes it difficult to make optimizations to hte index backfiller.
Since we already have other tests that make sure backfills are rolled
back correctly, we can remove this one.

Release note: None
@rafiss
rowexec: add concurrency to ingestIndexEntries
770f281 
Ingesting the index entries and writing them in bulk is the most
expensive part of an index backfill, and it's mostly I/O bound. Profiles
show that there is also a fair amount of computational overhead during
this step, so using an additional goroutine will allow more work to be
performed in parallel while the other goroutine is doing I/O.

Release note: None
@rafiss
roachtest: make indexschemachange test more consistent
5662367 
This patch disables the backup schedule, which would cause I/O resource
contention with the backfill, and it disables the metamorphic leases
setting so that the settings are consistent across different runs.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-138781 branch from 32648d9 to 5662367 Compare January 16, 2025 14:42
@blathers-crl blathers-crl bot requested review from a team as code owners January 16, 2025 14:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 16, 2025
@blathers-crl blathers-crl bot requested review from mw5h and removed request for a team January 16, 2025 14:42
@blathers-crl blathers-crl bot requested review from annrpom and mgartner January 16, 2025 14:42
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jan 16, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 16, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 3eec173 into release-25.1 Jan 16, 2025
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-25.1-138781 branch January 16, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annrpom annrpom annrpom approved these changes

@mw5h mw5h Awaiting requested review from mw5h mw5h is a code owner automatically assigned from cockroachdb/sql-queries-prs

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @annrpom @rafiss