Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: bazel: upgrade to Bazel 7.2.1 #127919

Merged

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Jul 30, 2024

Backport 1/1 commits from #127868.

/cc @cockroachdb/release

Release justification: Build-only code changes


We set -DBAZEL_TRACK_SOURCE_DIRECTORIES=1 as a workaround for a bug in rules_js. See aspect-build/rules_js#1408 for more details.

Closes #123237
Epic: CRDB-17171

Release note: None

We set `-DBAZEL_TRACK_SOURCE_DIRECTORIES=1` as a workaround for a bug in
`rules_js`. See aspect-build/rules_js#1408 for more details.

Closes cockroachdb#123237
Epic: CRDB-17171

Release note: None
@rickystewart rickystewart requested a review from rail July 30, 2024 20:04
@rickystewart rickystewart requested review from a team as code owners July 30, 2024 20:04
@rickystewart rickystewart requested review from kyle-a-wong, srosenberg and vidit-bhat and removed request for a team July 30, 2024 20:04
Copy link

blathers-crl bot commented Jul 30, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@rickystewart rickystewart requested review from yuzefovich and removed request for a team July 30, 2024 20:04
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 30, 2024
@rickystewart rickystewart requested review from msbutler and removed request for a team July 30, 2024 20:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit fcbaa71 into cockroachdb:release-24.2 Jul 31, 2024
19 of 20 checks passed
@rickystewart rickystewart deleted the backport24.2-127868 branch July 31, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants