Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix lease_preferences configure zone #118308

Merged

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Jan 25, 2024

e2a5b35 updated the lease_prefernces roachtest to use configureZone
but incorrectly specified just "kv" as the zone target. Update the zone
target to correctly include the database qualifier.

Fixes: #118304
Informs: #117311
Release note: None

@kvoli kvoli requested a review from a team as a code owner January 25, 2024 15:11
@kvoli kvoli requested review from DarrylWong and renatolabs and removed request for a team January 25, 2024 15:11
@kvoli kvoli self-assigned this Jan 25, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

e2a5b35 updated the `lease_prefernces` roachtest to use `configureZone`
but incorrectly specified just "kv" as the zone target. Update the zone
target to correctly include the database qualifier.

Fixes: cockroachdb#118304
Informs: cockroachdb#117311
Release note: None
@kvoli kvoli force-pushed the 240125.roachtest-fix-lease-preferences branch from 8c46197 to e0fb3b1 Compare January 25, 2024 15:14
@kvoli
Copy link
Collaborator Author

kvoli commented Jan 25, 2024

TYFTR

bors r=shralex

@craig
Copy link
Contributor

craig bot commented Jan 25, 2024

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Jan 26, 2024

Build succeeded:

@craig craig bot merged commit e1c807d into cockroachdb:master Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: lease-preferences/full-first-preference-down failed
3 participants