Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align filter for internal on active stmt/txn with sessions #81072

Closed
2 tasks
maryliag opened this issue May 5, 2022 · 0 comments · Fixed by #83014
Closed
2 tasks

align filter for internal on active stmt/txn with sessions #81072

maryliag opened this issue May 5, 2022 · 0 comments · Fixed by #83014
Assignees
@ericharmeling
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@maryliag
Copy link
Contributor

maryliag commented May 5, 2022 •
edited by cockroach-jira-scripts
Loading

Right now we have

  • Active Statements: doesn't show internal queries at all or internal app filter
  • Active Transaction: show internal transactions and the app filter have each internal app as an item
  • Sessions: doesn't show internal apps by default and have a filter with all internal app names grouped in a single "$internal"

Since those 3 tabs are related to Active Executions and they all use the same source of data they should be compatible, so the Active Statement and Transactions should be updated to have the same behaviour as Sessions:

  • Under the App filter show a single $internal that show/hide all internal statement/transactions
  • Don't show internal by default, but if that filter is select, those executions are displayed

Jira issue: CRDB-15366
@maryliag maryliag added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels May 5, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@maryliag maryliag assigned ericharmeling and unassigned xinhaoz Jun 7, 2022
@ericharmeling ericharmeling mentioned this issue Jun 16, 2022
Merged
craig bot pushed a commit that referenced this issue Jul 7, 2022
@ericharmeling @stevendanna
@msbutler @tbg
Merge #83014 #83707 #84003 #84039
2dd8e76 
83014: ui: add internal app filter to active statements and transactions pages r=ericharmeling a=ericharmeling

This PR adds a single internal app filter option on to the Active Statements and Active Transactions pages. Active
statements and transactions run by internal apps are no longer displayed by default.

See commit message for release note.


https://user-images.githubusercontent.com/27286675/174156635-39d8649a-df91-4550-adb5-b3c167d54ed5.mov



Fixes #81072.

83707: roachtest: run workload from the tenant node r=knz a=stevendanna

The secure URL refers to paths on disk on the clusters in the
node. Since we only create the tenant-scoped certs on the tenant node,
we need to run workload from that node.

Fixes #82266
Depends on #83703

Release note: None

84003: storage: close pebble iter gracefully when NewPebbleSSTIterator fails r=erikgrinaker a=msbutler

Currently, if `pebble.NewExternalIter` sets pebbleIterator.inuse to True, but
then fails, the subsequent `pebbleIterator.destroy()` will panic unecessarily,
since the caller of `pebble.NewExternalIter` is not actually using the iter.
This bug causes TestBackupRestoreChecksum to flake in #83984.

To fix, this patch uses pebble.Close() to  gracefully close the pebbleIterator
if `pebble.NewExternalIter` fails.

Release Note: None

84039: prometheus: use older node_exporter r=nicktrav a=tbg

v1.3.1, the most up to date released version, has a bug that inflates
the bytes written by ~8x for NVMe drives (which in particular includes
the default drives for our GCE roachprod machines). Fundamentally this
is caused by the fact that these devices use a 4K sector size whereas
the kernel will always report based on a 512B sector size.

This took us a while to figure out, and to avoid repeating this exercise
periodically, downgrade node_exporter to 1.2.2, which pre-dates a
refactor that introduces the regression.

See: prometheus/node_exporter#2310

Release note: None


Co-authored-by: Eric Harmeling <eric.harmeling@cockroachlabs.com>
Co-authored-by: Steven Danna <danna@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
@craig craig bot closed this as completed in #83014 Jul 7, 2022
@ericharmeling ericharmeling mentioned this issue Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericharmeling ericharmeling

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add internal app filter to active statements and transactions pages ericharmeling/cockroach
4 participants
@jlinder @maryliag @xinhaoz @ericharmeling