format: do not output 0's after decimals for coeff < -2000 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otan
force-pushed
the
coeff_fix
branch
2 times, most recently
from
7702a69
to
ba96220
Compare
otan
changed the title
In Cockroach, the minimum supported coefficient for 0 is -2000. To avoid the memory overload that occurs when we try format a large 0 coefficient like `0E-10000`, we amend the fix made in ffd11b1 to only output trailing zeroes up to -2000.
miretskiy
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cockroach, the minimum supported coefficient for 0 is -2000. To avoid the memory overload that occurs when we try format a large 0 coefficient like
0E-10000, we amend the fix made in ffd11b1 to only output trailing zeroes up to -2000.