Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): use copy rule for unmodified files #13781

Closed
wants to merge 1 commit into from

Conversation

hoinmic
Copy link
Contributor

@hoinmic hoinmic commented Mar 24, 2020

Several elements were not handled correctly in the Makefiles. This led to different behavior in different environments.
This fix applies the copy rule to all unchanged files between dist and pkg folders.
Fixes #13554

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented in issue #13554

@hoinmic
Copy link
Contributor Author

hoinmic commented Apr 2, 2020

Questions answered in issue #13554

@hoinmic
Copy link
Contributor Author

hoinmic commented Apr 7, 2020

@martinpitt Would it be possible to start the checks/tests? Then I would have a CI feedback in this merge request.

@martinpitt
Copy link
Member

@hoinmic: Can do, I started a debian and a fedora test; but we won't land it as such, it's too ad-hoc and duplicating webpack.

@hoinmic
Copy link
Contributor Author

hoinmic commented Apr 7, 2020

@martinpitt I think to correct the current makefiles nothing else is possible with little effort.
It corrects in its entirety all of the miss copy artifacts in all parts of the makefiles.
For some embedded devices Cockpit would be great, but if desired I can withdraw my annoying merge request.

@hoinmic hoinmic closed this Apr 12, 2020
@hoinmic hoinmic deleted the fix/makefile branch May 13, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yocto, devtool modify
2 participants