Skip to content

tests: fix for lxml 6 #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thunze wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: fix for lxml 6 #1334

thunze wants to merge 1 commit into from

Conversation

@thunze
Copy link

@thunze thunze commented Nov 29, 2025 •
edited
Loading

lxml 6 doesn't find a <body> tag via the XPath expression //body anymore when the parsed HTML doesn't contain any tags at all. This currently causes the following tests to fail when lxml 6 is used:

Version 0.21.0:

tests/test_djangoclient.py::DjangoClientDriverTest::test_is_text_present_and_should_wait_time
tests/test_djangoclient.py::DjangoClientDriverTestWithCustomHeaders::test_create_a_phantomjs_with_custom_headers
tests/test_flaskclient.py::FlaskClientDriverTest::test_is_text_present_and_should_wait_time
tests/test_flaskclient.py::FlaskClientDriverTestWithCustomHeaders::test_create_a_flask_client_with_custom_headers
tests/test_zopetestbrowser.py::ZopeTestBrowserDriverTest::test_is_text_present_and_should_wait_time

master at the time of writing (8615391):

tests/tests_django/test_custom_headers.py::test_create_a_django_client_with_custom_headers
tests/test_all_drivers/test_is_text_present.py::test_is_text_present_and_should_wait_time

See https://hydra.nixos.org/build/314264704/nixlog/1 for logs of the test failures. Note that these logs were obtained by running the test suite of version 0.21.0 and the tests have apparently been restructured since then. I'm pretty sure the underlying test failures are the same though.

This PR fixes these test failures by wrapping fake web server responses that currently don't have a <body> tag with <html><body>...</body></html>.

@thunze
tests: fix for lxml 6
9efb790 
lxml 6 doesn't find a `<body>` tag via the XPath expression `//body`
anymore when the parsed HTML doesn't contain any tags at all.
This caused some of splinter's tests to fail when lxml 6 is used.

See https://hydra.nixos.org/build/314264704/nixlog/1 for logs of
the test failures.
@thunze thunze mentioned this pull request Nov 29, 2025
Merged
13 tasks
fsouza
fsouza approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@thunze
Copy link
Author

thunze commented Dec 7, 2025

@fsouza Sure thing!

I don't think the CI failures are related to this change, can you confirm this?

@fsouza
Copy link
Contributor

fsouza commented Dec 7, 2025

yeah I think that's a flaky test, let me see if a retry will turn it green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsouza fsouza fsouza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thunze @fsouza