Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add JSON Schema #55

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Docs: Add JSON Schema #55

merged 1 commit into from
Feb 23, 2023

Conversation

tiltingpenguin
Copy link
Collaborator

@tiltingpenguin tiltingpenguin commented Feb 13, 2023

First draft for the JSON Schema to validate the distro signatures

Fixes: #39

@SchoolGuy SchoolGuy added this to the v1.0.0 milestone Feb 13, 2023
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add https://github.com/OrRosenblatt/validate-json-action to validate if both the schema and current JSON match each other.

@tiltingpenguin tiltingpenguin force-pushed the feature/add-json-schema branch from 2cec29e to 242bd0b Compare February 21, 2023 14:06
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would kindly ask you to squash all commits into the first commit.

Additionally, we should add a note in the documentation on how to use the JSON schema as a user.

Docs: Add signatures file and add Validation

fix signatures to fit schema

make architectures enums

Update docs for JSON Schema

Add required keys
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the organizations of the distro_signatures.json files we will discuss inside a split-out issue.

@SchoolGuy SchoolGuy merged commit 82eb97c into main Feb 23, 2023
@SchoolGuy SchoolGuy deleted the feature/add-json-schema branch February 23, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

JSON Schema
2 participants