Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4783] Add integration builder how-to guide for GitHub #543

Merged

Conversation

TaylorBriggs
Copy link
Contributor

@TaylorBriggs TaylorBriggs commented Sep 23, 2024

Changelog

Added

Page Deploy Preview Comment
GitHub https://deploy-preview-543--cobalt-docs.netlify.app/integrations/integrationbuilder/how-to-guides/github/ How-to guide for setting up a GitHub recipe using Integration Builder

Preview This Change

To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/

Variables

Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:

{{% asset-categories %}}

You’ve found a shortcode that we include in multiple documents.

You’ll find the content of the shortcode in the following directory:

https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes

That shortcode has the same base name as what you see in the PR, such as asset-categories.html.

Checklist for PR Author

[ ] Did you check for broken links and alt text?

Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for cobalt-docs ready!

Name Link
🔨 Latest commit 03e2a8c
🔍 Latest deploy log https://app.netlify.com/sites/cobalt-docs/deploys/66f336920ab436000839f974
😎 Deploy Preview https://deploy-preview-543--cobalt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TaylorBriggs TaylorBriggs force-pushed the chore/FX-4783/integration-builder-guide-github-issues branch from f5c8228 to b2cf2c0 Compare September 23, 2024 21:06
Copy link
Contributor

@grayson-cobalt grayson-cobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@@ -0,0 +1,95 @@
---
title: "GitHub"
linkTitle: "GitHub"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of naming the article "Push findings to GitHub" instead of just "GitHub"?


## Set up the GitHub connection

1. Click the create connection button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth mentioning that they need to navigate to the projects tab first.


![Recipe library](/integrations/integration_builder/how_to_guides/github/09_recipe-library.png "Recipe library")

2. Click on the recipe you want to use and copy it into the folder created in step 5 above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might move the "copy it into the folder created in step 5 above." part to be above the screenshot that shows the "use this recipe" button. We also might call out that the user needs to click the "use this recipe" button so they know how to do the copy

3. You will need to customize the recipe to use your GitHub organization and
repository. Click the button to customize the recipe, then enter or select your
organization and repository name in the required fields. Make sure you save the
recipe after customizing it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then enter or select your organization and repository name in the required fields

For some users to understand this, they will need to be told what action to click on to find the fields they need to fill out

organization and repository name in the required fields. Make sure you save the
recipe after customizing it.

![Start customizing](/integrations/integration_builder/how_to_guides/github/13_customize-recipe-start.png "Start customizing")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we also told the user how they can customize the content of the GitHub issues the integration creates.

@@ -0,0 +1,95 @@
---
title: "GitHub"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a generalized feedback: I've found that it helps people figure out where to click if I put a red box around the button they should click in screenshots. I add this using Preview (built into mac) then use the annotate > rectangle tool

@TaylorBriggs TaylorBriggs requested review from grayson-cobalt and a team September 24, 2024 17:12

## Test the recipe

To test the recipe with pentest findings, follow the guide for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed it, but I couldn't find instructions on where/how to change the pentest for which issues should be created. The "Edit the recipe" section comes close to that, but doesn't explicitly mention that the pentest can be selected there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even think about this. @grayson-cobalt can correct me if I'm wrong, but I believe it will fire for all pentests/findings within the org by default.

I just looked at it more carefully and the trigger can be set to fire for either a specific asset or a pentest. There are also trigger conditions, but that already links out to external documentation so I'm not sure I need to add anything about that.

I'll add a section for how to update the trigger.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I wasn't aware the trigger worked for the whole org as well. Then there's probably no need to mention it, maybe just a note.

@TaylorBriggs
Copy link
Contributor Author

@mahmoudadly-cobalt @wolfgangbecker I made a folder for How to Guides under IntegrationBuilder thinking that the pages we're working on would all go there. We don't have to do it that way, I just thought it would make it more organized. Let me know what you think of that approach.

@wolfgangbecker
Copy link
Contributor

@mahmoudadly-cobalt @wolfgangbecker I made a folder for How to Guides under IntegrationBuilder thinking that the pages we're working on would all go there. We don't have to do it that way, I just thought it would make it more organized. Let me know what you think of that approach.

Yes, I saw that and applied it to #544 as well. I agree this is better to keep things organized.

Copy link
Contributor

@grayson-cobalt grayson-cobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you!!

@grayson-cobalt grayson-cobalt merged commit fa2db86 into main Sep 25, 2024
10 checks passed
@grayson-cobalt grayson-cobalt deleted the chore/FX-4783/integration-builder-guide-github-issues branch September 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants