Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Jan 15, 2026

No description provided.

@fwiesel fwiesel force-pushed the development branch 2 times, most recently from 9735d5f to 173b6f2 Compare January 27, 2026 10:12
It doesn't make sense to poll openstack for the hypervisors, when
we are still evicting.
The HypervisorMaintenanceController already disabled the
compute-service, so drop doing that in the eviction controller.
We just wait for the condition to be reached.
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 55.45% (-0.05%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller.go 53.73% (-0.96%) 67 (+3) 36 (+1) 31 (+2) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller.go 30.56% (-7.17%) 144 (-76) 44 (-39) 100 (-37) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 71.60% (ø) 81 58 23

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller_test.go

@fwiesel fwiesel closed this Jan 28, 2026
@fwiesel fwiesel deleted the development branch January 28, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants