Add driver tests and figure out why the interner isn't working #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver tests test the compilation of an entire file or collection of files, from generating executables to linking libraries. These are particularly helpful for testing compatibility on different platforms.
Driver tests test the compilation of an entire file or collection of files, from generating executables to linking libraries. These are particularly helpful for testing compatibility on different platforms.
Driver tests test the compilation of an entire file or collection of files, from generating executables to linking libraries. These are particularly helpful for testing compatibility on different platforms.
matt-cornell
approved these changes
Jan 17, 2024
matt-cornell
force-pushed
the
breadth-tests
branch
from
7ab16b0 to
b5ebf45
Compare
matt-cornell
force-pushed
the
breadth-tests
branch
from
9743068 to
5c7beec
Compare
matt-cornell
force-pushed
the
breadth-tests
branch
from
cf47f87 to
3b4039a
Compare
matt-cornell
changed the title
Collaborator
|
I don't know why the interner is breaking like this, but we need to fix this before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we don't have (formal) tests that test the user-facing product, that is, test the entire compilation process. Unit tests are important, but it's useful to also have these tests. They are also a useful last-defense against inadvertent breaking changes, particularly when these tests run on multiple platforms.
Summary
Adds the following tests: