Skip to content

Preset UI Improvements and Save Workflow Fix#62

Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
feature/preset-improvements-v0.7.16-4724824329777617554
Open

Preset UI Improvements and Save Workflow Fix#62
google-labs-jules[bot] wants to merge 1 commit intomainfrom
feature/preset-improvements-v0.7.16-4724824329777617554

Conversation

@google-labs-jules
Copy link
Contributor

This update addresses the user's request for better preset organization and a streamlined save process.

Key changes:

  1. User Preset Priority: In the preset dropdown, user presets are now loaded right after the "Default" preset, placing them above the long list of built-in hardware and test presets.
  2. Persistent Selection: The application no longer switches to "Custom" mode as soon as a slider is touched. Instead, it maintains the reference to the selected preset and indicates its "dirty" state with a * suffix.
  3. Streamlined Saving: The "Save Current Config" button has been improved to dynamically update its label and behavior. If a user preset is currently selected and modified, the button allows saving directly back to that preset without renaming.
  4. Refactored Backend: Added GetUserInsertionPoint helper in Config.cpp to deduplicate logic across Add, Duplicate, and Import operations.
  5. Stability Fix: Resolved a code review concern regarding the usage of temporary engines during startup migrations, ensuring user global settings are never accidentally reset to defaults.

Version bumped to 0.7.16. All 473 unit tests passing.


PR created automatically by Jules for task 4724824329777617554 started by @coasting-nc

- Reordered presets in the dropdown list: User-saved presets now appear at the top (immediately after the "Default" preset) for easier access.
- Refactored internal preset management: Centralized user preset insertion logic to maintain consistent ordering.
- Improved "Save" workflow: The GUI now preserves the current preset selection even when settings are modified, allowing direct updates to the active user preset.
- Enhanced Save Button: Renamed "Save Current Config" to be context-aware (e.g., "Save to 'MyPreset'") when a user preset is selected.
- Fixed Safety Issue: Removed risky auto-save from `Config::LoadPresets()` to prevent accidental overwriting of global settings during legacy migrations.
- Updated unit tests to support preset reordering and verified overwrite logic.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants