Skip to content

πŸ› οΈ Fixer: FFB Safety and Feature Decoupling (v0.7.48)#125

Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fixer-ffb-safety-decoupling-v0748-4246810051260517654
Open

πŸ› οΈ Fixer: FFB Safety and Feature Decoupling (v0.7.48)#125
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fixer-ffb-safety-decoupling-v0748-4246810051260517654

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses multiple reliability and physics logic issues identified in the v0.7.48 development cycle.

πŸ› Issues:

  • Scrub Drag was unintentionally disabled when Road Texture was off.
  • FFB forces could "stick" on the wheel if the game crashed or disconnected.
  • Road Texture was capped at 2.0x, which was reported as too weak by some users.
  • Slide Rumble was too sensitive, causing vibrations on straights.

πŸ”§ Fixes:

  • Scrub Drag: Moved logic outside the m_road_texture_enabled early exit in FFBEngine.h.
  • FFB Safety: Moved DirectInputFFB::UpdateForce outside the connection check in main.cpp and ensured the force variable is reset to 0.0 every iteration.
  • Tuning: Increased texture_safe_max clamp to 10.0 and effective_slip_vel threshold to 1.5 m/s in FFBEngine.h.

πŸ›‘οΈ Safety:

  • The change in main.cpp ensures that the wheel is always zeroed out if the game is not driving or disconnected, preventing high-force "hangs" that could be dangerous.

🐧 Linux Note:

  • All 220 tests passed in the Linux headless environment, including a new regression test for Scrub Drag independence.

PR created automatically by Jules for task 4246810051260517654 started by @coasting-nc

- Decoupled Scrub Drag from Road Texture toggle in FFBEngine.h.
- Improved FFB safety in main.cpp by zeroing force on disconnect.
- Increased Road Texture load cap clamp to 10.0.
- Reduced Slide Rumble sensitivity (1.5 m/s threshold).
- Verified with Linux test suite (220 tests passed).
@google-labs-jules
Copy link
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

Comments