π οΈ Fixer: FFB Safety and Feature Decoupling (v0.7.48)#125
π οΈ Fixer: FFB Safety and Feature Decoupling (v0.7.48)#125google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Decoupled Scrub Drag from Road Texture toggle in FFBEngine.h. - Improved FFB safety in main.cpp by zeroing force on disconnect. - Increased Road Texture load cap clamp to 10.0. - Reduced Slide Rumble sensitivity (1.5 m/s threshold). - Verified with Linux test suite (220 tests passed).
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses multiple reliability and physics logic issues identified in the v0.7.48 development cycle.
π Issues:
π§ Fixes:
m_road_texture_enabledearly exit inFFBEngine.h.DirectInputFFB::UpdateForceoutside the connection check inmain.cppand ensured theforcevariable is reset to 0.0 every iteration.texture_safe_maxclamp to 10.0 andeffective_slip_velthreshold to 1.5 m/s inFFBEngine.h.π‘οΈ Safety:
main.cppensures that the wheel is always zeroed out if the game is not driving or disconnected, preventing high-force "hangs" that could be dangerous.π§ Linux Note:
PR created automatically by Jules for task 4246810051260517654 started by @coasting-nc