Skip to content

🛠️ Fixer: Hardware Safety and Physics Stability Improvements#101

Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-ffb-stuck-and-slope-stability-13801308144254955951
Open

🛠️ Fixer: Hardware Safety and Physics Stability Improvements#101
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-ffb-stuck-and-slope-stability-13801308144254955951

Conversation

@google-labs-jules
Copy link
Contributor

Improved reliability and safety of the FFB engine. Resolves issues with forces remaining active after game exit, excessive slide noise on straights, and instability in Slope Detection for DLC cars. Added regression tests and verified stability.


PR created automatically by Jules for task 13801308144254955951 started by @coasting-nc

Summary:
- Hardware Safety: Ensured FFB motor is zeroed when the game exits or FFB is deactivated by moving the UpdateForce call in main.cpp.
- Noise Reduction: Reduced Slide Texture over-sensitivity on straights by increasing the effective_slip_vel threshold from 0.5 to 1.5 m/s.
- Stability: Improved Slope Detection (DLC grip estimation) by increasing the default slope_max_threshold to -5.0 and hardening the protected_denom clamp to 0.01.
- Added regression tests in tests/test_fixer_fixes.cpp.
- Verified all 202 tests pass on Linux.

Fixes several user reports about notchiness and stuck forces.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants