Merged
Conversation
…at least it compiles)
Member
|
Awesome!! Thanks for the support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's only almost 6 years late, but finally here.
The CNFA WASAPI driver now supports audio output.
Additionally, I've restructured the code a fair bit, cleaned it up, and also made it respect the user's requests for sample rates and channel counts. To accomplish that, I've given WASAPI the task of resampling/mixing to/from the requested format on our behalf.
I've tested the audio output using MSVC, Clang, and TCC (via
example.c). I've additionally verified that input still works correctly in colorchord using Clang and TCC. All only on Windows of course.I tried using the WAV player as an additional test case, and made it compilable on Windows as well, but it seems to be rather broken. It doesn't handle several of the WAV files I had handy, and even one Sam provided didn't work correctly. It likely needs some work.