Autosize of windows is not work properly on different DPI scalings

[Alexpux]

On Win10 when you change scaling factor in settings layouts autosize not work properly. From demo projects here is inputbox pictures for 100%, 125% and 150% scaling:

go to: #698

[cnjinhao]

Thank you for reporting this issue. I will check it.

[edgarbernal5]

Hi! I don't know if it is the same issue but when I moved the form created in a 4k monitor to a HD monitor the title bar (caption, minimize, maximize, etc) won't scale the title bar correctly.

4K monitor

HD monitor

[edgarbernal5]

Also I managed to scale menubar with different DPI by getting widget size of it. Here is the code within source/gui/widgets/menubar.cpp

std::size_t find(const ::nana::point& pos)
{
  // changed this line:
  if ((2 <= pos.x) && (2 <= pos.y) && (pos.y < 25))
  
  //with this:
  auto menubar_size = widget_ptr->size();
  if ((2 <= pos.x) && (2 <= pos.y) && (pos.y < menubar_size.height))

....

Also on refresh method

void trigger::refresh(graph_reference graph)
{
....
  auto menubar_size = ess_->widget_ptr->size();
  nana::point item_pos(2, 2);
  nana::size item_s(0, menubar_size.height - 2);
...

What do you think? Thanks in advance.
There is still a bug with menu popoups

[cnjinhao]

@edgarbernal5 a PR is welcomed.

[edgarbernal5]

Hi @cnjinhao, I want to contribute, I have a commit ready to be pushed but I think I don't have right access:

git push --set-upstream origin dpi_scale_issue
remote: Permission to cnjinhao/nana.git denied to edgarbernal5.
fatal: unable to access 'https://github.com/cnjinhao/nana.git/': The requested URL returned error: 403

[qPCR4vir]

@edgarbernal5 make your push into your own fork of nana https://github.com/edgarbernal5/nana, and from there open a pull request to the original fork.

[edgarbernal5]

Alright, I didn't know that! Thanks @qPCR4vir will do that!

[edgarbernal5]

In order to create the pull request, should I create a branch in my own fork with all in? @qPCR4vir

[edgarbernal5]

I think I know the answer 😀

[edgarbernal5]

Pull request: #690.
Any feedback is welcomed.

[cnjinhao]

Pull request: #690.

Any feedback is welcomed.

Thanks, the pull request has been merged.

[qPCR4vir]

Pull request: #690. Any feedback is welcomed.

Hi ! It looks like a great job. I hope you (@edgarbernal5 ) will keep doing soo.

But in your Pull Request you (@edgarbernal5 ) made the same mistake I made some times: there are a lot of unrelated commits that make it very hard to follow what you did. I'm sorry that I did not review that, and only now report it. To fix this I propose that you both go to the previous commit: 7c73095 "fix crash and rectangle errors in pixel_buffer" and make a hard reset of the branch to that. @cnjinhao will need to rewrite that to the repo (force push that branch again). After that one (@edgarbernal5 ) need to do a merge , but using a 'cherry pick' and include only the commit fe75360 "Fixed dpi scale for menu, menubar and combox". In a new Pull request verify only that commit was made. @cnjinhao will then merged and made a new push. This will re-write history. A clean history. There are many ways to do this, just verify before push. If you want I can try to do all of that by myself. We all learn by doing...

[edgarbernal5]

My bad, it was my fault! I want to fix this but I don't know how to do it right! We can do it together if you want @qPCR4vir

I got the following message:

git reset --hard 7c73095
fatal: Could not parse object '7c73095f26e4a7e2b29af6097e692ba7e2cd6d71'.

or doing this:

git checkout 7c73095
fatal: reference is not a tree: 7c73095

Probably I am missing something.
By the way I want to do the same thing in my fork, to clean the mess, because this project is awesome and want to continue developing and contributing not only with bug fixing but also with creating new widgets.

[qPCR4vir]

ok... I did what I could.. I hope it is not too bad now.
@cnjinhao and @edgarbernal5 will need to rename your local branch develop-1.8 and pull it again from this repo.

@edgarbernal5 to clean your repo just rename your develop-1.8 to my_dev-1.8 or something and pull a fresh develop-1.8 from this repo. Then create a new branch directly from that fresh pulled develop-1.8 with the name of the feature or fix you want to provide. Checkout that and cherry pick only the commits that you want to merge. Push to your repo in GitHub and from there make a PullRequest to cnjinhao/develop-1.8. Make sure it is a clean PR, with only the needed commits and changes.
Good luck!