Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on multiple files #12

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Don't fail on multiple files #12

merged 1 commit into from
Jan 4, 2021

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Jan 2, 2021

When dumping multiple (non-UTF-8 encoded) files, the output is a _io.BufferedWriter instead of _io.TextIOWrapper.
The former has no available "encoding" property.

When dumping multiple (non-UTF-8 encoded) files, the output is a `_io.BufferedWriter` instead of `_io.TextIOWrapper`.
The former has no available "encoding" property.
Copy link
Owner

@cneud cneud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cneud cneud merged commit 3654e65 into cneud:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants