Update README.md #155
Merged
Update README.md #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
@mikebrow I think you may need to sign-off the commit to satisfy the DCO requirement. |
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
mikebrow
force-pushed
the
mikebrow-patch-1-1
branch
from
a3bc0ce
to
75158b4
Compare
| @@ -75,7 +75,7 @@ command to find them out: | |||
| $ crio config |& grep -B1 -A5 cdi_spec_dirs | |||
| ``` | |||
|
|
|||
| ### Containerd configuration | |||
| ### containerd configuration | |||
|
|
|||
| To enable and configure CDI support in the [containerd | |||
There was a problem hiding this comment.
how about adding? i ended up looking for this information to try out, which would be useful for other uses?
Suggested change
| To enable and configure CDI support in the [containerd | |
| [cotnainerd v1.7.0](https://github.com/containerd/containerd/releases/tag/v1.7.0) or later required. | |
| To enable and configure CDI support in the [containerd |
There was a problem hiding this comment.
maybe.. there is a chance we are going to backport support for CDI hook injection to the 1.6LTS branch, depending on alpha->beta promotion status in the upcoming k8s v1.29 release
klihub
approved these changes
Sep 6, 2023
|
merged bypassing the DCO check that had not run. Confirmed that the commit was signed-off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a quick nit fix to lower case containerd