Added an option to specify max idle time for a pooled socket. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment is done at the time of picking the socket out of the pool, not by timer.
|
This is more of a suggestion PR, as it hasn't been tested. In particular, the logic around proper time _semaphore.Release() isn't fully clear to me (added a comment in MemcachedNode.cs). |
romanpolunin
commented
Jan 4, 2023
|
|
||
| if (pair.socket is not null) | ||
| { | ||
| try { pair.socket.Destroy(); } catch { } |
There was a problem hiding this comment.
This may need a call to _semaphore.Release() here.
|
Thanks for your contribution. Please try EnyimMemcachedCore 2.6.0-preview2 |
cw-sanikachavan
pushed a commit
to carwale/EnyimMemcachedCore
that referenced
this pull request
Jan 17, 2025
…s#185) Add an option to specify max idle time for a pooled socket Co-authored-by: Roman Polunin <romanspo@gmail.com> Co-authored-by: dudu <dudu@cnblogs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When memcached nodes in a large memcached cluster are intentionally restarted, like a couple every day, connections to those nodes become stale. This change is to add an option to discard pooled sockets if they have not been picked up from the pool in the recent time - in our case this would be about a minute. Those "old" sockets are very likely to become stale (since they are rarely picked up from the _freeItems stack - that only happens during occasional spikes in server load).
Added an option to specify max idle time for a pooled socket.
Default value is zero, which turns this feature off.
Enforcement is done at the time of picking the socket out of the pool, not by timer.