Create a package.json and depend on sax #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmzmasek I can't assign you as a reviewer so I'm pinging you here |
|
Ping @cmzmasek |
1 similar comment
|
Ping @cmzmasek |
|
@cmzmasek would be great if you could merge this PR and make a new release on npm. current version does not allow to easily depend and reuse phyloxml. The PR looks good from my point of view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
package.jsonfile to publish to NPM. Depend on sax rather than requiring users to manually vendor sax.js into their own projects.Closes #6