Skip to content

Throwing panics over the FFI is UB #5

@maddiemort

Description

@maddiemort

I notice that in a few places within the playground-utils-ffi crate, calls to expect() are made, and within xi-ffi, several calls to assert!() are made.

As far as I understand, throwing panics over the FFI is UB, and I wanted to flag this to your attention; I would suggest these be replaced with some other method of indicating errors. I know that Mozilla's ffi-support crate provides utilities for helping with this, for example.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions