Revert incorrect optimizations to JSGF compiler (fixes #53) #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit was cmusphinx/sphinxbase@e59cac4 The resulting FSGs are, yes, quite bad, but the optimization was incorrect, and the proposed fix for it did not actually fix the problem, but made the code more complex. In general I think the Knuth quote about premature optimization is just an excuse for people to write bad code, but in this case it seems pertinent
The change I reverted was *partially* correct as it noted that a right-recursive rule cannot reach the final state on its own, so put this change back
with the side effect that it verifies the correctness of the tests in test-sphinx_jsgf2fsg.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also verify the correctness of the test grammars, with a new utility function that does this.
The optimization was, in theory, a good idea, perhaps it can be done correctly, now that we can properly verify the correctness of the resulting grammars.