Fix manylinux wheels not building (issue #265) #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
actually the wheels still don't quite build right, I am fixing now... |
|
There is no SWIG in the manylinux1 wheels, so I had to switch to manylinux2014 for all Python versions in build_wheels.sh. SWIG is probably going to be removed shortly anyway because as far as I can tell nobody actually uses its bindings for Ruby, it's a dependency that annoys a lot of people, and it's more difficult to produce a properly Pythonic API in it. I'll pull in the bindings from https://github.com/ReadAlongs/SoundSwallower and just ensure they remain compatible, probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.