Tls cert bugfix #262
Merged
Tls cert bugfix #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signed certs that expire in 10 years. Removed automatic cert generation from install-deps.sh. Updated create-cert.sh to manually generate 10year certs (or any custom duration).
|
Thanks! Unfortunately it looks like the Docker Hub auto-build has failed with the new image. Were you able to build the image on your system? https://hub.docker.com/r/bamos/openface/builds/bfcrr2vshnkackznkqgwoqw/ |
|
Sorry about that. This should be working. I'll do some more testing and see what the problem is. |
sunnylgz
pushed a commit
to sunnylgz/openface
that referenced
this pull request
Dec 28, 2017
* Bugfix for systems that cannot generate openssl certs. Includes self-signed certs that expire in 10 years. Removed automatic cert generation from install-deps.sh. Updated create-cert.sh to manually generate 10year certs (or any custom duration). * Docker config changes to support web demo TLS
liuwanjin365
pushed a commit
to liuwanjin365/openface
that referenced
this pull request
Apr 28, 2021
* Bugfix for systems that cannot generate openssl certs. Includes self-signed certs that expire in 10 years. Removed automatic cert generation from install-deps.sh. Updated create-cert.sh to manually generate 10year certs (or any custom duration). * Docker config changes to support web demo TLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fix adds the required dependencies to the docker and pip configs to support TLS for the web demo.
It also includes pre-generated self-signed certs that will expire in ten years and removes the call to create-certs.sh from install-deps.sh. This avoids users having to actually create the certs unless the want to.
Where should the reviewer start?
How should this PR be tested?
Run the docker image (after it's been created). The demo webapp should start properly with no openssl related errors. The docker url is now https://docker_ip:8000
I tested it on win10, I can test it again once the docker image is rebuilt.
Any background context you want to provide?
Docker was missing a few required libraries to support TLS in python. Also the install-deps script which created the certs is not included in the docker config so it was never generating the certs. To avoid the extra complication of creating the certs, I just opted for including pre-generated long lived certs with the option of generating new ones (via create-cert.sh)
What are the relevant issues?
#261
Screenshots (if appropriate)
Questions:
Yes (the url is now https not http)
Yes it adds both OS package and python packages