Skip to content

Proofread and changed formatting #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ploparmor
Copy link

This is my first series of pull request, throw me some feedback if anyone gets back to this project.
Hi there, nice project. Haven't gotten to try it out myself

changes:

Proofread,
removed the <center></center> formatting in some places because it looked broken on github,
reduced usage of centered "example" headers over the codeblocks,
changed json flavored markdown codeblocks to json5

Interning for SCADA downtown but have done relatively little programming so I'm delegated to recreating system arcitecture documentation and reseaching SCADA basics like this.

reiterate: This is my first series of pull request, throw me some feedback if anyone gets back to this project. I realize I don't need to write a whole paper here but thanks for reading! -D

@LeeFromTexas
Copy link

are you still at CMU? I'm working on a SCADA related project and would love to learn more about this project. ltrawick@andrew.cmu.edu

@ploparmor
Copy link
Author

ploparmor commented Feb 18, 2020

@therockotter I'm not attending CMU, I just had some related learning to do about some SCADA work and they asked me to familiarize myself with generally what is in a SCADA. Saw this project and the broken formatting on the readme and decided to fix it real quick.
I'm still not particularly sure if it's setup to work because I didn't test it or anything.

@LeeFromTexas
Copy link

LeeFromTexas commented Feb 19, 2020 via email

@chemch
Copy link

chemch commented Oct 10, 2020

Is this project still active/working? Hitting some issues getting the HMI and PLCs to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants