[Refactor] `insert_or_update_bulk` is a thin wrapper around `insert_or_update_batch` without a purpose?

[dshemetov]

in src/acquisition/covidcast/database.py we have:

  def insert_or_update_bulk(self, cc_rows):
    return self.insert_or_update_batch(cc_rows)

minor nit: this wrapper doesn't seem to do anything...

Originally posted by @dshemetov in #903 (comment)

[dshemetov]

@krivard @melange396 thoughts? feels like a legacy wrapper that used to do something, but eventually became paper thin

[xavier-xia-99]

It does seem like it. I just tested doing away without the insert_or_update_bulk and using batch only and it seems to be working normally. The original version with insert_or_update_batch was called with the same argument (covidcast rows); the rest are all default arguments.

[melange396]

yeah, istr that this once had some purpose, but its clearly gone now. it should be gotten rid of.

[melange396]

oh.. it looks like #948 might have done this but i cant make sense of the mass of changes in there. ill give the assignment to @xavier-xia-99

[melange396]

whoops, duplicated in #989 -- im going to close this one as that one has a larger scope now