Skip to content

bug(evalcast): remove title from labs in plots #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dshemetov merged 3 commits into from
Jun 23, 2023
Merged

bug(evalcast): remove title from labs in plots #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d0a0e5
bug(evalcast): remove title from labs in plots
dshemetov Jun 23, 2023
9256d12
bug(evalcast): remove github:: remote spec from DESCRIPTION
dshemetov Jun 23, 2023
e6a338c
docs+package: bump minor version and write changelog
dshemetov Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions R-packages/evalcast/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: evalcast
Type: Package
Title: Tools For Evaluating COVID Forecasters
Version: 0.3.1
Version: 0.3.2
Authors@R:
c(
person(given = "Daniel",
Expand Down Expand Up @@ -56,9 +56,9 @@ LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Remotes:
bettermc=github::gfkse/bettermc@v1.1.2,
zoltr=github::reichlab/zoltr,
covidHubUtils=github::reichlab/covidHubUtils
gfkse/bettermc@v1.1.2,
reichlab/zoltr,
reichlab/covidHubUtils
Imports:
assertthat,
covidcast,
Expand Down
6 changes: 6 additions & 0 deletions R-packages/evalcast/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# evalcast 0.3.2

- Fix DESCRIPTION remotes so `remotes` and `devtools` work
- Fix `plot_calibration` by removing badly specified titles in the `lab` argument
- Pin `bettermc` to the GitHub version 1.1.2 to avoid a CRAN error

# evalcast 0.3.1

- Added a download_signal caching folder option
Expand Down
8 changes: 2 additions & 6 deletions R-packages/evalcast/R/plot_calibration.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ format_wedgeplot <- function(calib,
geom_segment(aes(x = 0.5, y = 0.5, xend = 1, yend = 0),
size = 0.25, color = "black") +
labs(x = "Nominal quantile level",
y = "Proportion",
title = sprintf("%s (ahead = %s): Proportion above/below",
.data$name, .data$ahead)) +
y = "Proportion") +
scale_alpha_continuous(range = c(0.5, 1)) +
scale_size_continuous(range = c(0.5, 1)) +
guides(alpha = FALSE, size = FALSE) +
Expand Down Expand Up @@ -147,9 +145,7 @@ format_traditional_calib_plot <- function(calib,
ggplot(aes(x = .data$nominal_prob, y = .data$prop_below)) +
geom_abline(slope = 1, intercept = 0) +
labs(x = "Quantile level",
y = "Proportion",
title = sprintf("%s (ahead %s): Calibration",
.data$name, .data$ahead)) +
y = "Proportion") +
geom_line(aes(color = .data$color, group = .data$color)) +
scale_color_viridis_d() +
facet_layer
Expand Down