Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

remove junit from microbenchmark stage #1640

Merged
merged 1 commit into from
Nov 5, 2021
Merged

remove junit from microbenchmark stage #1640

merged 1 commit into from
Nov 5, 2021

Conversation

crd477
Copy link
Collaborator

@crd477 crd477 commented Nov 5, 2021

This stage does not produce any junit results anyway. The junit
Jenkins plugin prior to version 1.53 would silently ignore missing &
empty test result files. As of version 1.53, it produces an error that
fails the stage.

Signed-off-by: Chad Dougherty crd@acm.org

This stage does not produce any junit results anyway.  The junit
Jenkins plugin prior to version 1.53 would silently ignore missing &
empty test result files.  As of version 1.53, it produces an error that
fails the stage.

Signed-off-by: Chad Dougherty <crd@acm.org>
@crd477 crd477 requested a review from lmwnshn November 5, 2021 13:15
@crd477
Copy link
Collaborator Author

crd477 commented Nov 5, 2021

For a while, I was able to manually hold back the update to the junit plugin in Jenkins. As time went on, other plugins started specifying the newer version as a dependency so it's just easier to do the proper fix in the pipeline here.

@crd477 crd477 added the ready-for-ci Indicate that this build should be run through CI. label Nov 5, 2021
@apavlo apavlo merged commit 79276e6 into cmu-db:master Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-ci Indicate that this build should be run through CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants