This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 501
Enable changing the compiled_query_execution setting at runtime #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linmagit
added
ready-for-review
This PR passes all checks and is ready to be reviewed. Mark PRs with this.
ready-for-ci
Indicate that this build should be run through CI.
labels
Jun 6, 2021
lmwnshn
reviewed
Jun 6, 2021
Minor Decrease in PerformanceBe warned: this PR may have decreased the throughput of the system slightly.
|
Minor Decrease in PerformanceBe warned: this PR may have decreased the throughput of the system slightly.
|
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 80.74% 80.72% -0.02%
==========================================
Files 751 751
Lines 52791 52798 +7
==========================================
- Hits 42626 42623 -3
- Misses 10165 10175 +10
Continue to review full report at Codecov.
|
lmwnshn
added
ready-to-merge
This PR is ready to be merged. Mark PRs with this.
and removed
ready-for-review
This PR passes all checks and is ready to be reviewed. Mark PRs with this.
labels
Jun 7, 2021
lmwnshn
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-for-ci
Indicate that this build should be run through CI.
ready-to-merge
This PR is ready to be merged. Mark PRs with this.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CompiledQueryExecution
SettingsCallback
to change theexecution_mode_
setting inTrafficCop
. So that at run time, we can useSET
command to change thecompiled_query_execution
setting.Note that with the existing system architecture, the system only compiles the query when it executes the query as
Compiled
mode for the first time, instead of when constructing theExecutableQuery
. Once the query has been executed asCompiled
once, it can switch between theInterpert
andCompiled
modes without more compilation.