Fix DurabilityPolicy::DISABLE configuration.

[lmwnshn]

Heading

Fix DurabilityPolicy::DISABLE configuration.

Description

Fix #1595.

• Allow ReplicationPolicy::DISABLE to be set if DurabilityPolicy::DISABLE is also set.
• Immediately release the buffer segment if durability is disabled.
• Immediately remove any txn that commits if durability is disabled. (is this fine?)

Essentially trying to emulate the log manager off configuration.

[noisepage-checks]

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
1.9%	tpcc	RAM disk	Details master tps=22196.87, commit tps=22619.71, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
1.81%	tpcc	None	Details master tps=29494.84, commit tps=30029.36, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-2.81%	tpcc	HDD	Details master tps=21932.05, commit tps=21316.82, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
8.11%	tatp	RAM disk	Details master tps=6543.37, commit tps=7074.07, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
0.8%	tatp	None	Details master tps=7438.3, commit tps=7498.15, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
7.14%	tatp	HDD	Details master tps=6433.71, commit tps=6892.86, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

[codecov]

Codecov Report

Merging #1596 (f7ed218) into master (dbc4383) will increase coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head f7ed218 differs from pull request most recent head c1d031b. Consider uploading reports for the commit c1d031b to get more accurate results

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   81.22%   81.23%   +0.01%     
==========================================
  Files         747      747              
  Lines       52453    52452       -1     
==========================================
+ Hits        42603    42610       +7     
+ Misses       9850     9842       -8     

Impacted Files	Coverage Δ
src/transaction/transaction_manager.cpp	90.90% <0.00%> (-1.20%)	⬇️
src/include/transaction/transaction_context.h	97.82% <100.00%> (ø)
src/storage/record_buffer.cpp	100.00% <100.00%> (ø)
src/traffic_cop/traffic_cop.cpp	74.29% <100.00%> (-0.10%)	⬇️
src/execution/sql/sorter.cpp	96.73% <0.00%> (-0.55%)	⬇️
src/execution/vm/vm.cpp	83.90% <0.00%> (-0.15%)	⬇️
src/execution/sema/sema_builtin.cpp	61.54% <0.00%> (+0.09%)	⬆️
src/include/storage/index/bplustree.h	92.05% <0.00%> (+0.10%)	⬆️
src/execution/vm/bytecode_generator.cpp	84.20% <0.00%> (+0.17%)	⬆️
src/network/connection_handle.cpp	64.06% <0.00%> (+0.78%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc4383...c1d031b. Read the comment docs.