Internal Table Actions Recording #1575

17zhangw · 2021-05-06T03:48:44Z

Description

Builds upon existing internal table and task manager infrastructure to support recording actions. This PR records the chosen action that is applied and also records a portion of the search tree. The recorded search tree recorded by this PR consists of the nodes on the "best action sequence path" and (k - 1) next best siblings of the chosen node at each depth of the path.

Remaining tasks

Additional testing
Getting PR through CI

noisepage-checks · 2021-05-11T00:55:35Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-2.73%	tpcc	RAM disk	Details master tps=23064.52, commit tps=22434.78, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-0.22%	tpcc	None	Details master tps=29187.38, commit tps=29122.67, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
1.86%	tpcc	HDD	Details master tps=21540.94, commit tps=21941.47, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
5.98%	tatp	RAM disk	Details master tps=6483.85, commit tps=6871.5, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.34%	tatp	None	Details master tps=7478.93, commit tps=7453.21, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
3.89%	tatp	HDD	Details master tps=6483.06, commit tps=6735.3, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

codecov · 2021-05-11T00:55:40Z

Codecov Report

Merging #1575 (656b131) into master (30bd635) will decrease coverage by 0.14%.
The diff coverage is 4.61%.

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   81.89%   81.74%   -0.15%     
==========================================
  Files         738      739       +1     
  Lines       51942    52042     +100     
==========================================
+ Hits        42537    42543       +6     
- Misses       9405     9499      +94

Impacted Files	Coverage Δ
src/common/strong_typedef.cpp	`100.00% <ø> (ø)`
...lf_driving/planning/mcts/monte_carlo_tree_search.h	`0.00% <0.00%> (ø)`
src/include/self_driving/planning/mcts/tree_node.h	`0.00% <0.00%> (ø)`
src/include/self_driving/planning/pilot.h	`0.00% <ø> (ø)`
src/self_driving/forecasting/forecaster.cpp	`0.00% <0.00%> (ø)`
..._driving/planning/mcts/monte_carlo_tree_search.cpp	`0.00% <0.00%> (ø)`
src/self_driving/planning/mcts/tree_node.cpp	`0.00% <0.00%> (ø)`
src/self_driving/planning/pilot.cpp	`0.00% <0.00%> (ø)`
src/util/self_driving_recording_util.cpp	`33.08% <7.40%> (ø)`
src/metrics/query_trace_metric.cpp	`93.97% <100.00%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30bd635...656b131. Read the comment docs.

linmagit

Generally looks good! A few minor comments.

src/self_driving/planning/pilot.cpp

src/util/forecast_recording_util.cpp

src/self_driving/planning/mcts/monte_carlo_tree_search.cpp

noisepage-checks · 2021-05-14T19:56:09Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-1.62%	tpcc	RAM disk	Details master tps=22804.53, commit tps=22434.78, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-2.8%	tpcc	None	Details master tps=29960.48, commit tps=29122.67, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.27%	tpcc	HDD	Details master tps=21999.98, commit tps=21941.47, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
4.35%	tatp	RAM disk	Details master tps=6584.88, commit tps=6871.5, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.2%	tatp	None	Details master tps=7468.11, commit tps=7453.21, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
4.6%	tatp	HDD	Details master tps=6439.21, commit tps=6735.3, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

src/main/startup.sql

noisepage-checks · 2021-05-18T03:01:42Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-2.93%	tpcc	RAM disk	Details master tps=22881.27, commit tps=22210.04, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
0.17%	tpcc	None	Details master tps=29644.7, commit tps=29694.25, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-1.98%	tpcc	HDD	Details master tps=22160.08, commit tps=21720.82, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
3.19%	tatp	RAM disk	Details master tps=6594.73, commit tps=6804.85, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-2.23%	tatp	None	Details master tps=7512.6, commit tps=7345.08, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
4.44%	tatp	HDD	Details master tps=6468.51, commit tps=6755.63, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

noisepage-checks · 2021-05-18T23:30:25Z

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
-0.52%	tpcc	RAM disk	Details master tps=22501.53, commit tps=22383.77, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
0.93%	tpcc	None	Details master tps=28699.68, commit tps=28967.31, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-2.45%	tpcc	HDD	Details master tps=22235.69, commit tps=21691.04, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
3.35%	tatp	RAM disk	Details master tps=6661.66, commit tps=6885.12, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-0.42%	tatp	None	Details master tps=7484.3, commit tps=7453.05, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
5.39%	tatp	HDD	Details master tps=6539.58, commit tps=6891.83, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

Pass over the actions recording tables

45f0c66

17zhangw self-assigned this May 6, 2021

17zhangw added in-progress This PR is being actively worked on and not ready to be reviewed or merged. Mark PRs with this. ready-for-ci Indicate that this build should be run through CI. labels May 6, 2021

17zhangw added 2 commits May 10, 2021 15:11

Merge remote-tracking branch 'cmudb/master' into actions

da860bd

Actions fixes

c08073a

17zhangw requested a review from linmagit May 11, 2021 01:11

17zhangw added ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. and removed in-progress This PR is being actively worked on and not ready to be reviewed or merged. Mark PRs with this. labels May 11, 2021

linmagit suggested changes May 12, 2021

View reviewed changes

src/self_driving/planning/pilot.cpp Outdated Show resolved Hide resolved

src/util/forecast_recording_util.cpp Outdated Show resolved Hide resolved

src/self_driving/planning/mcts/monte_carlo_tree_search.cpp Show resolved Hide resolved

17zhangw added 2 commits May 17, 2021 19:14

Merge remote-tracking branch 'cmudb/master' into actions

29dd16e

Apply top and reverse

ef08ac4

linmagit reviewed May 18, 2021

View reviewed changes

src/main/startup.sql Outdated Show resolved Hide resolved

17zhangw added 3 commits May 18, 2021 15:57

Record start/end

a89d268

Fixes to start/end

c6c4df7

doxygen

656b131

linmagit approved these changes May 18, 2021

View reviewed changes

linmagit merged commit b95bf1e into cmu-db:master May 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal Table Actions Recording #1575

Internal Table Actions Recording #1575

17zhangw commented May 6, 2021 •

edited

Loading

noisepage-checks bot commented May 11, 2021

codecov bot commented May 11, 2021 •

edited

Loading

linmagit left a comment

noisepage-checks bot commented May 14, 2021

noisepage-checks bot commented May 18, 2021

noisepage-checks bot commented May 18, 2021

Internal Table Actions Recording #1575

Internal Table Actions Recording #1575

Conversation

17zhangw commented May 6, 2021 • edited Loading

Description

Remaining tasks

noisepage-checks bot commented May 11, 2021

Minor Decrease in Performance

codecov bot commented May 11, 2021 • edited Loading

Codecov Report

linmagit left a comment

Choose a reason for hiding this comment

noisepage-checks bot commented May 14, 2021

Minor Decrease in Performance

noisepage-checks bot commented May 18, 2021

Minor Decrease in Performance

noisepage-checks bot commented May 18, 2021

Minor Decrease in Performance

17zhangw commented May 6, 2021 •

edited

Loading

codecov bot commented May 11, 2021 •

edited

Loading