Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Nightly Microbenchmark JSON Fixes #1543

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Nightly Microbenchmark JSON Fixes #1543

merged 2 commits into from
Apr 15, 2021

Conversation

apavlo
Copy link
Member

@apavlo apavlo commented Apr 15, 2021

This PR does three things:

  • Strip debug statements from our system in the JSON output of the microbenchmarks.
  • Fixes the environment variables that we weren't setting correctly for the # of CPU cores + log path.
  • Adds a gitignore to hide the microbenchmark output files.

https://youtu.be/iin3ZVXot74

@apavlo
Strip debug statements from JSON results in microbenchmarks output. F…
dc397e5 
…ix environment variable names for microbenchmarks.
@apavlo apavlo added ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. tests This issue or PR concerns the testing infrastructure: Google Test, Google Benchmark, JUnit, etc. ready-for-ci Indicate that this build should be run through CI. labels Apr 15, 2021
@apavlo apavlo requested a review from lmwnshn April 15, 2021 16:52
lmwnshn
lmwnshn approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@lmwnshn lmwnshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

script/testing/microbench/micro_benchmarks_runner.py Show resolved Hide resolved
@lmwnshn lmwnshn added ready-to-merge This PR is ready to be merged. Mark PRs with this. and removed ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. labels Apr 15, 2021
@lmwnshn lmwnshn merged commit 95e8d5f into cmu-db:master Apr 15, 2021
@apavlo apavlo deleted the nightlyfix-apr2021 branch April 15, 2021 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmwnshn lmwnshn lmwnshn approved these changes

Assignees
No one assigned
Labels
ready-for-ci Indicate that this build should be run through CI. ready-to-merge This PR is ready to be merged. Mark PRs with this. tests This issue or PR concerns the testing infrastructure: Google Test, Google Benchmark, JUnit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apavlo @lmwnshn