Logging metrics sampling

[mbutrovich]

No description provided.

[lmwnshn]

LGTM

[noisepage-checks]

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change)	benchmark_type	wal_device	details
0.33%	tpcc	RAM disk	Details master tps=8894.4, commit tps=8923.61, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-0.23%	tpcc	None	Details master tps=9997.24, commit tps=9974.04, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-0.18%	tpcc	HDD	Details master tps=491.73, commit tps=490.84, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
1.95%	tatp	RAM disk	Details master tps=3462.28, commit tps=3529.82, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
-3.48%	tatp	None	Details master tps=3799.59, commit tps=3667.41, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
-3.14%	tatp	HDD	Details master tps=351.98, commit tps=340.92, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

[codecov]

Codecov Report

Merging #1516 (c9ffe9b) into master (68c0069) will increase coverage by 0.01%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   81.79%   81.80%   +0.01%     
==========================================
  Files         706      706              
  Lines       50425    50433       +8     
==========================================
+ Hits        41246    41258      +12     
+ Misses       9179     9175       -4     

Impacted Files	Coverage Δ
src/settings/settings_callbacks.cpp	63.96% <0.00%> (-3.02%)	⬇️
src/include/main/db_main.h	88.23% <100.00%> (+0.06%)	⬆️
src/include/settings/settings_defs.h	100.00% <100.00%> (ø)
src/include/metrics/metrics_store.h	61.66% <0.00%> (-1.67%)	⬇️
src/network/network_io_wrapper.cpp	80.64% <0.00%> (-1.62%)	⬇️
src/include/storage/index/bplustree.h	89.93% <0.00%> (+0.11%)	⬆️
src/include/execution/sql/chaining_hash_table.h	91.91% <0.00%> (+1.01%)	⬆️
src/storage/data_table.cpp	98.29% <0.00%> (+1.13%)	⬆️
src/network/connection_handle.cpp	64.84% <0.00%> (+1.56%)	⬆️
src/include/storage/sql_table.h	100.00% <0.00%> (+2.32%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c0069...c9ffe9b. Read the comment docs.