This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fix bplustree.h redefined constant shared with bwtree.h. #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmwnshn
added
best-practice
mbutrovich
reviewed
Feb 25, 2021
| namespace noisepage::storage::index { | ||
|
|
||
| // If node size goes above this then we split it | ||
| // Thresholds for Inner Node | ||
| #define INNER_NODE_SIZE_UPPER_THRESHOLD ((int)128) |
There was a problem hiding this comment.
These should have been constexpr but I guess we missed that on review. We'll do a #define sweep of the codebase again at a later date.
Performance Boost!Nice job! This PR has increased the throughput of the system. Could not find any performance results to compare for this commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heading
Fix bplustree.h redefined constant shared with bwtree.h.
Description
Some PRs are failing CI due to
#definedefinition leaking in some unity builds, and I think we'd like to avoid random define pollution in headers anyway.