This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 501
Fix storage interface, table vector iterator not being freed on abort. #1482
Merged
Commits on Feb 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 07cc989 - Browse repository at this point
Copy the full SHA 07cc989View commit details
Commits on Feb 21, 2021
-
Convert StorageInterface to be initialized at pipeline level instead …
…of inside a pipeline. Unfortunately this still leaks in TrafficCopTest's DisconnectAbort.
Configuration menu - View commit details
-
Copy full SHA for 66fb4d2 - Browse repository at this point
Copy the full SHA 66fb4d2View commit details
Commits on Feb 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8e6ffc6 - Browse repository at this point
Copy the full SHA 8e6ffc6View commit details -
Revert "Convert StorageInterface to be initialized at pipeline level …
…instead of inside a pipeline." This reverts commit 66fb4d2.
Configuration menu - View commit details
-
Copy full SHA for bc95c9d - Browse repository at this point
Copy the full SHA bc95c9dView commit details
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for edecb10 - Browse repository at this point
Copy the full SHA edecb10View commit details
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for edbae32 - Browse repository at this point
Copy the full SHA edbae32View commit details
Commits on Mar 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3a2cc5a - Browse repository at this point
Copy the full SHA 3a2cc5aView commit details
Commits on Mar 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 87fadeb - Browse repository at this point
Copy the full SHA 87fadebView commit details -
Revert "Revert "Convert StorageInterface to be initialized at pipelin…
…e level instead of inside a pipeline."" This reverts commit bc95c9d.
Configuration menu - View commit details
-
Copy full SHA for 4c32c8c - Browse repository at this point
Copy the full SHA 4c32c8cView commit details
Commits on Mar 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for df6f8ba - Browse repository at this point
Copy the full SHA df6f8baView commit details -
Add nasty boolean flag hack to track whether free(tvi) needs to be ca…
…lled in pipeline state teardown. Nesting adds new complications. The problem is that for a SeqScan, it might actually be nested inside another node like another SeqScan. So PipelineState is actually not quite the right level for any variable that can appear nested, because those will need to be setup/teardown'd per nested iteration instead of once per pipeline. But we shove it into the pipeline state anyway and basically generate an if for whether it needs to be freed. This raises the question of whether the other translators have similar issues. If they do and our tests don't catch it, then we probably need better tests...
Configuration menu - View commit details
-
Copy full SHA for 9d0c361 - Browse repository at this point
Copy the full SHA 9d0c361View commit details -
Configuration menu - View commit details
-
Copy full SHA for c266140 - Browse repository at this point
Copy the full SHA c266140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45c11cb - Browse repository at this point
Copy the full SHA 45c11cbView commit details
Commits on Mar 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 028be96 - Browse repository at this point
Copy the full SHA 028be96View commit details -
Configuration menu - View commit details
-
Copy full SHA for b159073 - Browse repository at this point
Copy the full SHA b159073View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a9ff29 - Browse repository at this point
Copy the full SHA 4a9ff29View commit details -
Undo change to index_create_translator which was already handling thi…
…ngs in pipeline state.
Configuration menu - View commit details
-
Copy full SHA for 4e80c8e - Browse repository at this point
Copy the full SHA 4e80c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ef190 - Browse repository at this point
Copy the full SHA 39ef190View commit details -
Configuration menu - View commit details
-
Copy full SHA for c78dec7 - Browse repository at this point
Copy the full SHA c78dec7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.