Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix storage interface, table vector iterator not being freed on abort. #1482

Merged
merged 19 commits into from
Mar 15, 2021

Commits on Feb 20, 2021

  1. Configuration menu
    Copy the full SHA
    07cc989 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Convert StorageInterface to be initialized at pipeline level instead …

    …of inside a pipeline.
    
    Unfortunately this still leaks in TrafficCopTest's DisconnectAbort.
    lmwnshn committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    66fb4d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    8e6ffc6 View commit details
    Browse the repository at this point in the history
  2. Revert "Convert StorageInterface to be initialized at pipeline level …

    …instead of inside a pipeline."
    
    This reverts commit 66fb4d2.
    lmwnshn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    bc95c9d View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    edecb10 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    edbae32 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Configuration menu
    Copy the full SHA
    3a2cc5a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Configuration menu
    Copy the full SHA
    87fadeb View commit details
    Browse the repository at this point in the history
  2. Revert "Revert "Convert StorageInterface to be initialized at pipelin…

    …e level instead of inside a pipeline.""
    
    This reverts commit bc95c9d.
    lmwnshn committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    4c32c8c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Configuration menu
    Copy the full SHA
    df6f8ba View commit details
    Browse the repository at this point in the history
  2. Add nasty boolean flag hack to track whether free(tvi) needs to be ca…

    …lled in pipeline state teardown.
    
    Nesting adds new complications.
    The problem is that for a SeqScan, it might actually be nested inside another node like another SeqScan.
    So PipelineState is actually not quite the right level for any variable that can appear nested,
    because those will need to be setup/teardown'd per nested iteration instead of once per pipeline.
    
    But we shove it into the pipeline state anyway and basically generate an if for whether it needs to be freed.
    
    This raises the question of whether the other translators have similar issues.
    If they do and our tests don't catch it, then we probably need better tests...
    lmwnshn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    9d0c361 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c266140 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    45c11cb View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Configuration menu
    Copy the full SHA
    028be96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b159073 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a9ff29 View commit details
    Browse the repository at this point in the history
  4. Undo change to index_create_translator which was already handling thi…

    …ngs in pipeline state.
    lmwnshn committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    4e80c8e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    39ef190 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c78dec7 View commit details
    Browse the repository at this point in the history