Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Synchronous Replication #1472

Merged
merged 103 commits into from
Mar 9, 2021
Merged

Synchronous Replication #1472

merged 103 commits into from
Mar 9, 2021

Commits on Nov 2, 2020

  1. Checkpoint. New replication manager.

    @lmwnshn
    lmwnshn committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    641bf6c View commit details
    Browse the repository at this point in the history

  2. tmp unpush

    @lmwnshn
    lmwnshn committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    c27168f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. Checkpoint. Fix messenger_test.

    @lmwnshn
    lmwnshn committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3854236 View commit details
    Browse the repository at this point in the history

  2. Refactor the Messenger with Matt's suggestion. 

    Instead of sender and receiver callback IDs, which I got confused by,
use source and destination callback IDs. This is helpful when writing
callbacks that take in a ZmqResponse message, because now the source
is clearly the remote host and the destination is clearly the local host,
whereas previously sender is ambiguous since the receiver is now sending
a message to the original sender. That last sentence is itself confusing.
    @lmwnshn
    lmwnshn committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    b47569b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Checkpoint.

    @lmwnshn
    lmwnshn committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    6e13413 View commit details
    Browse the repository at this point in the history

  2. Checkpoint. Replication locally via noisepage. Pretty sure tests brok… 

    …e (API).
    @lmwnshn
    lmwnshn committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    0de754e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    afb1280 View commit details
    Browse the repository at this point in the history

  2. Switch to sanctionedsharedptr for logger.

    @lmwnshn
    lmwnshn committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    5584bd4 View commit details
    Browse the repository at this point in the history

  3. Nuke dead code.

    @lmwnshn
    lmwnshn committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    ea976b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Eliminate potential race in messenger_test.

    @lmwnshn
    lmwnshn committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    26c2e87 View commit details
    Browse the repository at this point in the history

  2. Checkpoint.

    @lmwnshn
    lmwnshn committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    80f7767 View commit details
    Browse the repository at this point in the history

  3. Checkpoint.

    @lmwnshn
    lmwnshn committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    375fb14 View commit details
    Browse the repository at this point in the history

  4. Checkpoint.

    @lmwnshn
    lmwnshn committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    0d4a470 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Checkpoint.

    @lmwnshn
    lmwnshn committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    410cd96 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Add Tianlei's ReplicationLogProvider port.

    @tpan496 @lmwnshn
    tpan496 authored and lmwnshn committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    73cf888 View commit details
    Browse the repository at this point in the history

  2. Add support for simple replication.

    @lmwnshn
    lmwnshn committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    ef64dd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Checkpoint. Slight progress. ty matt

    @lmwnshn
    lmwnshn committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    bd407cb View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Fix the replica not returning serialized buffers to the empty buffer … 

    …queue.

Additionally, change replication to blocking to make it more reliable.
However, this is unacceptably slow and should be undone at some point.
    @lmwnshn
    lmwnshn committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5ca79ba View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. unpush me later.

    @lmwnshn
    lmwnshn committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    4d83efd View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    380abb4 View commit details
    Browse the repository at this point in the history

  2. Checkpoint.

    @lmwnshn
    lmwnshn committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    ed0c6bd View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Checkpoint. Add dummy replication_get_last_record_id builtin.

    @lmwnshn
    lmwnshn committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    e9803b6 View commit details
    Browse the repository at this point in the history

  2. Checkpoint. Nuke the ITP legacy stuff. Hook up replication manager an… 

    …d exec ctx.
    @lmwnshn
    lmwnshn committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    0acb22d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Checkpoint. Shutdown, except we had to add some DBMain stuff that I s… 

    …hould check with someone.
    @lmwnshn
    lmwnshn committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    4739b65 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    7d7d2ba View commit details
    Browse the repository at this point in the history

  3. Checkpoint. recovery_test is failing?

    @lmwnshn
    lmwnshn committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    730f62c View commit details
    Browse the repository at this point in the history

  4. Minor cleanup.

    @lmwnshn
    lmwnshn committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    3bf0b14 View commit details
    Browse the repository at this point in the history

  5. Simplify cleanup logic.

    @lmwnshn
    lmwnshn committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    f17cbe8 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Fix RecoveryManager race-y logic. Add documentation and warnings. 

    One day for this piffly little thing...
    @lmwnshn
    lmwnshn committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e6a738f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into replication

    @lmwnshn
    lmwnshn authored Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a458409 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Documentation.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    dde1ef6 View commit details
    Browse the repository at this point in the history

  2. add retention policy

    @tpan496 @lmwnshn
    tpan496 authored and lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6c61675 View commit details
    Browse the repository at this point in the history

  3. Checkpoint. Doxygen fixes and reverting to changes that I'm not comfo… 

    …rtable adding without supporting comments.
    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    72fcf94 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into replication

    @lmwnshn
    lmwnshn authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    95f2aa4 View commit details
    Browse the repository at this point in the history

  5. Format.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    9ec03e4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8741991 View commit details
    Browse the repository at this point in the history

  7. Small fix after removing unused variable.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    63fae63 View commit details
    Browse the repository at this point in the history

  8. Clang-tidy doesn't like excessive padding.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    05b0d56 View commit details
    Browse the repository at this point in the history

  9. Update db_main comments.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3e04d56 View commit details
    Browse the repository at this point in the history

  10. Update settings comment.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8336a14 View commit details
    Browse the repository at this point in the history

  11. Update RecoveryManager comment.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    0d26d03 View commit details
    Browse the repository at this point in the history

  12. Move TODO around.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    2521f90 View commit details
    Browse the repository at this point in the history

  13. Update comment.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    b939e0e View commit details
    Browse the repository at this point in the history

  14. Add explicit.

    @lmwnshn
    lmwnshn committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    85d8908 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Fix parameter naming. I swear I did this already.

    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    03f468b View commit details
    Browse the repository at this point in the history

  2. Fix transaction_manager weirdness. Still a bit iffy on this...

    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    edfcff9 View commit details
    Browse the repository at this point in the history

  3. Checkpoint. 

    Refactor replication simple testing script.
Add replication simple testing to CI.
Change treatment of the replication.conf path.
    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    8d2c807 View commit details
    Browse the repository at this point in the history

  4. Checkpoint. 

    Some replication manager documentation changes.
Also fix heartbeat logic.
    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    861cf5f View commit details
    Browse the repository at this point in the history

  5. Checkpoint. 

    Tiny replication manager style things.
    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1b5af2a View commit details
    Browse the repository at this point in the history

  6. gitignore...

    @lmwnshn
    lmwnshn committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f5ef916 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Checkpoint. 

    True synchronous replication (hopefully).
Code is a bit meh. Will clean it up more.
    @lmwnshn
    lmwnshn committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    99dc705 View commit details
    Browse the repository at this point in the history

  2. Fix mini runners.

    @lmwnshn
    lmwnshn committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    51e2ffa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into replication

    @lmwnshn
    lmwnshn authored Feb 19, 2021
    Configuration menu
    Copy the full SHA
    4d9ff46 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    507df4c View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Merge branch 'replication' of github.com:lmwnshn/noisepage into repli… 

    …cation
    @lmwnshn
    lmwnshn committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    0c86727 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    23d3fda View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Add ninja job pools. Num logical cores = compile pool + link pool (1)… 

    … + 1.
    @lmwnshn
    lmwnshn committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    5e014f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ninja_link' into replication

    @lmwnshn
    lmwnshn committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    c371699 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge branch 'master' into replication

    @lmwnshn
    lmwnshn authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    554961e View commit details
    Browse the repository at this point in the history

  2. Store Messenger IPC locally instead of in /tmp. Also delete IPC file … 

    …at teardown and if it exists on startup.
    @lmwnshn
    lmwnshn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    a2e48db View commit details
    Browse the repository at this point in the history

  3. Don't hang if the other node dies in sync replication.

    @lmwnshn
    lmwnshn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    8cd8c57 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    0c515a6 View commit details
    Browse the repository at this point in the history

  2. Format.

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b568f14 View commit details
    Browse the repository at this point in the history

  3. Fix bplustree.h redefined constant shared with bwtree.h.

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    9430157 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bplustree_fix' into replication

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e040415 View commit details
    Browse the repository at this point in the history

  5. Lint.

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3c81a4f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bplustree_fix' into replication

    @lmwnshn
    lmwnshn committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3a1684f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Add logging for enabling/disabling replication.

    @lmwnshn
    lmwnshn committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    86b2a11 View commit details
    Browse the repository at this point in the history

  2. Fix bug in replica_sync.

    @lmwnshn
    lmwnshn committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    1042ae7 View commit details
    Browse the repository at this point in the history

  3. Add (what I hope is) the description of the right message in Replicat… 

    …ionManager buffering.
    @lmwnshn
    lmwnshn committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    47a804e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Remove dead code.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    6fa6ec2 View commit details
    Browse the repository at this point in the history

  2. Refactor PrepareForSerialization.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    cf9e5b3 View commit details
    Browse the repository at this point in the history

  3. Remove dead message.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    2b56dee View commit details
    Browse the repository at this point in the history

  4. Remove superfluous unlock.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    612d3e5 View commit details
    Browse the repository at this point in the history

  5. Remove debug logging.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    107053f View commit details
    Browse the repository at this point in the history

  6. Checkpoint. First pass at separating out primary/replica logic in Rep… 

    …licationManager.
    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    0e05526 View commit details
    Browse the repository at this point in the history

  7. Checkpoint. Add documentation, including for the BufferedLogWriter mo… 

    …ve ctor.
    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5e6b544 View commit details
    Browse the repository at this point in the history

  8. Refactor json message keys into a ReplicateBufferMessage container cl… 

    …ass.
    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    6414138 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of github.com:cmu-db/noisepage into replication

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5c90e42 View commit details
    Browse the repository at this point in the history

  10. Add warning comment on message delivery failure.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    d24cf2c View commit details
    Browse the repository at this point in the history

  11. Fix clang-tidy.

    @lmwnshn
    lmwnshn committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    146c903 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Stash the "primary" constant into the PrimaryReplicationManager.

    @lmwnshn
    lmwnshn committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    e89354e View commit details
    Browse the repository at this point in the history

  2. Move the replication test to the top.

    @lmwnshn
    lmwnshn committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    e3547bc View commit details
    Browse the repository at this point in the history

  3. Try switching localhost to 127.0.0.1.

    @lmwnshn
    lmwnshn committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    caba0b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Merge branch 'master' into replication

    @lmwnshn
    lmwnshn authored Mar 6, 2021
    Configuration menu
    Copy the full SHA
    acc2cda View commit details
    Browse the repository at this point in the history

  2. Add top information to print_docker_info.

    @lmwnshn
    lmwnshn committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    8142da4 View commit details
    Browse the repository at this point in the history

  3. Try disabling ccache.

    @lmwnshn
    lmwnshn committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    61d9aad View commit details
    Browse the repository at this point in the history

  4. Revert "Try disabling ccache." 

    This reverts commit 61d9aad.
    @lmwnshn
    lmwnshn committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    04ffc5d View commit details
    Browse the repository at this point in the history

  5. Revert "Stash the "primary" constant into the PrimaryReplicationManag… 

    …er."

This reverts commit e89354e.
    @lmwnshn
    lmwnshn committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    7a13faf View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Sin by sleeping. CI...

    @lmwnshn
    lmwnshn committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    34685bc View commit details
    Browse the repository at this point in the history

  2. Try fixing a potential race between ListenForConnection() and the con… 

    …nection actually being ready. If this works, I owe rickyx something.
    @lmwnshn
    lmwnshn committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    466deee View commit details
    Browse the repository at this point in the history

  3. blyat

    @lmwnshn
    lmwnshn committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    851502a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Nope. Didn't work. Back to having a 30 second sleep.

    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4a9936e View commit details
    Browse the repository at this point in the history

  2. It might have been the SNDRCV timeout of 1 second. Try bumping that u… 

    …p to 30.
    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e027b92 View commit details
    Browse the repository at this point in the history

  3. I AM A MONKEY OF THE HIGHEST ORDER. 

    More seriously, the messenger listen used to be the last message.
Now it is back to the domain socket listen being the last message.
    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f6627fa View commit details
    Browse the repository at this point in the history

  4. Avoid signalling cvars if there are no routers to add.

    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4d24ade View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into replication

    @mbutrovich
    mbutrovich authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    bd80a73 View commit details
    Browse the repository at this point in the history

  6. Switch back to the model where the Messenger is responsible for invok… 

    …ing all SendMessage-related callbacks,

before the server loop gets a chance to operate on the message.
    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    649f051 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/replication' into replication

    @lmwnshn
    lmwnshn committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4560cf5 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Rearchitect the server loop structure to rely on key_message_type ins… 

    …tead of destination callback ID, in line with the model server manager.
    @lmwnshn
    lmwnshn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    fcba2ca View commit details
    Browse the repository at this point in the history

  2. Add some messenger documentation.

    @lmwnshn
    lmwnshn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    e85036f View commit details
    Browse the repository at this point in the history

  3. Add documentation on why routers are added with a level of indirection.

    @lmwnshn
    lmwnshn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    8898968 View commit details
    Browse the repository at this point in the history

  4. Delete dead comment.

    @lmwnshn
    lmwnshn committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    9868193 View commit details
    Browse the repository at this point in the history