Resolves Issue 97 - classpath conflicts from various driver jars #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml # src/main/java/com/oltpbenchmark/benchmarks/tpch/TPCHLoader.java
timveil
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #97. To accomplish this I introduced the concept of maven profiles and moved database specific drivers from the default dependency list into profile specific dependency configurations. This means that instead of their being a single build/distribution of benchbase, there is now a build for each supported database. This eliminates the existing (#97) and future classpath challenges caused by shipping benchbase with every supported driver in the classpath.
These above changes also required me to make changes to the way github actions executes builds and tests. I was able to refactor our actions using
matrixstrategies to simplify the configuration and introduce more parallelization.The readme file, including build instructions have been updated to reflect this new approach