Key to CKey, Second Round#12652
Open
fira wants to merge 6 commits into
Open
Conversation
added 3 commits
July 14, 2026 11:27
fira
added
the
Needs Testing
cmss13-ci
Bot
added
Admin
realforest2001
approved these changes
Jul 16, 2026
github-project-automation
Bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Basically change key_name to output ckey in almost all cases, rather than the key.
Explain why it's good for the game
Without this many logs are simply not exploitable because you don't know what to search for.
It's easy enough to canonize the search terms, but it is impossible to perform a search in the logging backend that conforms to all the possible original keys.
The most common case is that of a key with a single space in it, which is already enough to prevent finding any relevant logs.
Testing Photographs and Procedure
Did summary testing on local by using a couple sources of logging. That probably won't catch everything especially with multiple users and real different keys.
Changelog
🆑
admin: Many logs, admin messages, and attack logs now are normalized to use the ckey rather than full key - this is important in regard to consistency for searching in logs for example
admin: Users in admin messages will now be marked as disconnected even if there is no PM link for them
admin: Ghosted or otherwise out-of-body users will now show their previous ckey in admin messages rather than no key
/:cl: