feat: Add movement unit tests#12648
Conversation
Add unit tests to validate behavior for collisions on move and for link blocked calls
|
Why not do the tests with an human rather than a movable to throw even more failure conditions in the loop? But either way this is great. Did you try to fail it selectively too? |
Wanted to just setup basic tests for parent movable since most of the logic that would cause a collision/link block are coming from the blockers rather than the mover. We can always build on top of these basic tests to validate logic for specific blockers (e.g., cargo flaps) and movers (e.g., observers).
Good idea, I did selective failing by allowing all movement/blocking all movement and updated testing screenshots with those runs + code changes. |
|
Looks like I didn't update description with the other unit tests runs, updated it |
|
Neato. I need to sit and review this thoroughly at some point, it's quite beefy |
Add unit tests to validate behavior for collisions on move and for link blocked calls
About the pull request
Adds unit tests validating collision and linked blocked behavior
Extracted from this PR: https://github.com/cmss13-devs/cmss13/pull/7138/changes
Explain why it's good for the game
Unit testing is good
Testing Photographs and Procedure
Happy path unit test results on VS Code
All movement blocked unit test results on VS Code
All movement allowed unit test results on VS Code
Changelog
🆑
add: Movement unit tests
/:cl: