refactor: Replace throwing and rebounding vars with traits#12635
Open
boskoramen wants to merge 1 commit into
Open
refactor: Replace throwing and rebounding vars with traits#12635boskoramen wants to merge 1 commit into
boskoramen wants to merge 1 commit into
Conversation
cmss13-ci
Bot
added
Refactor
boskoramen
force-pushed
the
launched-rebounding-trait
branch
from
July 13, 2026 00:38
f46b0e6 to
cc83088
Compare
github-project-automation
Bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
fira
added
the
Testmerge Candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Change extracted from launching refactor PR: https://github.com/cmss13-devs/cmss13/pull/7110/changes
Replaces throwing and rebounding state variables with traits
Explain why it's good for the game
Reduces vars on movable atoms that are only used for tracking state on a specific system (launching movement system)
Testing Photographs and Procedure
I just tested throwing for a few use cases: crusher charger, runner pounce, catching smart discs for preds, and rebounding by throwing items at walls.
Think it'd be more constructive to test this in TM.
Changelog
🆑 TheDonkified
refactor: Replace throwing and rebounding datum-level vars with traits
/:cl: