refactor: Require all overrides of Crossed to call parent#12623
refactor: Require all overrides of Crossed to call parent#12623boskoramen wants to merge 1 commit into
Conversation
Refactor step triggers so calls to Trigger happen at the parent step trigger class and conditions behind triggered are defined in provided function Mini refactor on smoke to use a variable for triggering smoke effects rather than overriding the Crossed function
cmss13-ci
Bot
added
Refactor
fira
left a comment
fira
left a comment
There was a problem hiding this comment.
Looks pretty good to me, might need quick live test to catch any edge cases
| handle_rotation() | ||
|
|
||
|
|
||
| /// Called when `crossed_by` enters the atom's turf (via native Move() or doMove() if allowed). |
There was a problem hiding this comment.
Technically you can Cross inside contents aswell, not neccessarily on a turf
fira
added
the
Testmerge Candidate
Test merge deployment history:Test Merge Deployed @ 07/16/2026 11:51:46 +00:00:Server InstanceRevisionTest Merge Updated @ 07/17/2026 00:08:37 +00:00:Server InstanceRevisionTest Merge Updated @ 07/17/2026 06:57:53 +00:00:Server InstanceCM13 Live RevisionOrigin: 2edb173 Test Merge Updated @ 07/17/2026 20:27:33 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 03:05:33 +00:00:Server InstanceCM13 Live RevisionOrigin: 8f06b5c Test Merge Updated @ 07/18/2026 04:04:01 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 09:08:09 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 13:26:08 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 14:11:21 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 15:18:50 +00:00:Server InstanceRevisionTest Merge Updated @ 07/18/2026 16:11:05 +00:00:Server InstanceRevisionTest Merge Updated @ 07/19/2026 05:15:51 +00:00:Server InstanceCM13 Live RevisionOrigin: 236040e Test Merge Updated @ 07/19/2026 08:17:36 +00:00:Server InstanceCM13 Live RevisionOrigin: 36e499a Test Merge Updated @ 07/19/2026 13:44:35 +00:00:Server InstanceRevisionTest Merge Updated @ 07/19/2026 15:20:22 +00:00:Server InstanceRevisionTest Merge Updated @ 07/19/2026 17:21:49 +00:00:Server InstanceCM13 Live RevisionOrigin: a53136d Test Merge Updated @ 07/20/2026 03:55:36 +00:00:Server InstanceCM13 Live RevisionOrigin: 0bdad2e Test Merge Updated @ 07/20/2026 15:00:04 +00:00:Server InstanceRevisionTest Merge Updated @ 07/20/2026 17:31:53 +00:00:Server InstanceCM13 Live RevisionOrigin: d868ecf Test Merge Updated @ 07/20/2026 18:02:45 +00:00:Server InstanceCM13 Live RevisionOrigin: bcf2ba5 Test Merge Updated @ 07/20/2026 18:33:37 +00:00:Server InstanceCM13 Live RevisionOrigin: bcd8a3f Test Merge Updated @ 07/21/2026 03:37:14 +00:00:Server InstanceCM13 Live RevisionOrigin: f572452 Test Merge Updated @ 07/21/2026 09:03:03 +00:00:Server InstanceRevisionTest Merge Updated @ 07/21/2026 10:10:17 +00:00:Server InstanceRevisionTest Merge Updated @ 07/21/2026 10:27:57 +00:00:Server InstanceRevision |
|
No issues reported so far |
3 participants
About the pull request
First change as part of a series of changes to refactor the launching into a subsystem. Extracted from my original PR here: #7110
Explain why it's good for the game
Routing all Crossed calls to parent will allow us to have signals setup on Crossed
Part of a larger charge to move launching into a subsystem, which should be preferable to sleeps
Testing Photographs and Procedure
Testing ARES step triggers
Triggers broadcast for AI mob as expected
dreamseeker_y146Zsh9Ox.mp4
Testing facehugger Crossed trigger
dreamseeker_7L1kmrCNc9.mp4
Testing bloody feet Crossed trigger
Blood decal causes bloody feet, bloody tracks does NOT cause bloody feet
dreamseeker_6uH04mHxHu.mp4
Testing boiler gas Crossed trigger
Boiler gas does not cause damage on Crossed
dreamseeker_216kleajJx.mp4
Testing fast resin does not cause slow down
dreamseeker_2DJHLCv85i.mp4
Changelog
🆑 TheDonkified
refactor: Refactors Crossed function so that all calls to Crossed must route to the parent Crossed function
/:cl: