fea: Merge mu/ele workflows and several updates #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mondalspandan
commented
Jul 18, 2024
•
mondalspandan
commented
- helper:add new xs
- scripts:assertion
- scripts: hadd, lfn for fetch
- data: add JERC
- metadata: remove duplications
- utils: add array_writer
- wf: merge Wc/tt and rename, merge e/mu DY, ttdilep
- wf: use array writer
- env: force black to certain version
- metadata:remove bad files - scripts: implement remove bad files in fetch.py script - plot: fix wrong axis defintion & add new variables definitions - helpers: update xsections - wf: add pv info & weight info in BTA_ttbar_wf
Conflicts: metadata/test_bta_run3.json
- ci: only trigger if changes - doc,ci: add customize commit message to run ci - wf: fix dtype bug
- ci: only trigger if changes - doc,ci: add customize commit message to run ci - wf: fix dtype bug
Changes to which variables are looked for, changes in output structure, etc.
Merge master
feat: new xsec, add assertion - helper:add new xs - scripts:assertion - scripts: hadd feat: merge array_writer - utils: add array_writer - wf: merge Wc/tt and rename, merge e/mu DY, ttdilep - wf: use array writer
Ming-Yan
force-pushed
the
master
branch
4 times, most recently
from
e55bda8 to
a3f02ce
Compare
Ming-Yan
changed the title
Ming-Yan
approved these changes
Jul 20, 2024
|
git ci issue leave for next PR |
Ming-Yan
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Hi @mondalspandan sorry not noticing this earlier, can you please have a look?
Comment on lines
+289
to
+291
| # & ( | ||
| # (dilep_mass.mass < 80) | (dilep_mass.mass > 100) | ||
| # ) |
There was a problem hiding this comment.
Shouldn't we still keep Z-mass veto?
Comment on lines
+108
to
+110
| dxySigcut = 0 # 1 | ||
| muNeEmSum = 1 # 0.7 | ||
| muonpTratioCut = 1 # 0.4 |
There was a problem hiding this comment.
Does the changes on purpose here?
also muonpTratio cut =1 means no selection?
If I understand correctly, you want to sync selection between e/mu channel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.